diff options
author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2023-10-09 15:30:31 +0200 |
---|---|---|
committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2023-11-02 12:06:50 +0100 |
commit | 47eeba4a4a7302662f4c39ebcc8e15a7876f8227 (patch) | |
tree | 03a261af2d0ca532607c1e949a344799bee1d02a /src/buildtool/serve_api/serve_service/source_tree.hpp | |
parent | c1a58d73d2fa21f9c692bbe3895443d3afc43d1d (diff) | |
download | justbuild-47eeba4a4a7302662f4c39ebcc8e15a7876f8227.tar.gz |
just serve: Fix inconsistencies
- add missing serve_api TARGETS file
- rename service client to align with server naming scheme
- fix inconsistencies in comments between implementation and protocol
Diffstat (limited to 'src/buildtool/serve_api/serve_service/source_tree.hpp')
-rw-r--r-- | src/buildtool/serve_api/serve_service/source_tree.hpp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/buildtool/serve_api/serve_service/source_tree.hpp b/src/buildtool/serve_api/serve_service/source_tree.hpp index 089844a1..a74de455 100644 --- a/src/buildtool/serve_api/serve_service/source_tree.hpp +++ b/src/buildtool/serve_api/serve_service/source_tree.hpp @@ -33,15 +33,9 @@ class SourceTreeService final : public justbuild::just_serve::SourceTree::Service { public: - // Retrieve the tree of a commit. + // Retrieve the Git-subtree identifier from a given Git commit. // - // This request interrogates the service whether it knows a given Git - // commit. If requested commit is found, it provides the commit's - // Git-tree identifier. - // - // Errors: - // - // * `NOT_FOUND`: The requested commit could not be found. + // There are no method-specific errors. auto ServeCommitTree( ::grpc::ServerContext* context, const ::justbuild::just_serve::ServeCommitTreeRequest* request, @@ -58,11 +52,11 @@ class SourceTreeService final gsl::not_null<IExecutionApi::Ptr> const local_api_{ CreateExecutionApi(std::nullopt)}; - [[nodiscard]] static auto GetTreeFromCommit( + [[nodiscard]] static auto GetSubtreeFromCommit( std::filesystem::path const& repo_path, std::string const& commit, std::string const& subdir, std::shared_ptr<Logger> const& logger) -> std::optional<std::string>; }; -#endif +#endif // INCLUDED_SRC_BUILDTOOL_SERVE_API_SERVE_SERVICE_SOURCE_TREE_HPP |