diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2022-12-23 17:18:42 +0100 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2022-12-23 18:29:08 +0100 |
| commit | 0374b80dd407d7b35654a01e3c7526b749d3464e (patch) | |
| tree | d0e62aece120c764ad557501e60398317c7dc77a /src/other_tools/ops_maps/git_update_map.cpp | |
| parent | 1de5a178bc804209eeeb512023de1ce4d77eef42 (diff) | |
| download | justbuild-0374b80dd407d7b35654a01e3c7526b749d3464e.tar.gz | |
Just-MR: Remove wrong pass-by-reference when wrapping loggers
Passing the logger by reference would require the caller to be
kept alive. Also, being a shared_ptr, the logger can be passed
by value at almost no cost.
Diffstat (limited to 'src/other_tools/ops_maps/git_update_map.cpp')
| -rw-r--r-- | src/other_tools/ops_maps/git_update_map.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/other_tools/ops_maps/git_update_map.cpp b/src/other_tools/ops_maps/git_update_map.cpp index b1172084..73eccfe0 100644 --- a/src/other_tools/ops_maps/git_update_map.cpp +++ b/src/other_tools/ops_maps/git_update_map.cpp @@ -45,7 +45,7 @@ auto CreateGitUpdateMap(GitCASPtr const& git_cas, std::size_t jobs) } // setup wrapped logger auto wrapped_logger = std::make_shared<AsyncMapConsumerLogger>( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)( fmt::format("While updating commit via tmp repo:\n{}", msg), fatal); |