Age | Commit message (Collapse) | Author | |
---|---|---|---|
9 days | Clarify use of a clang-tidy check | Paul Cristian Sarbu | |
The google-default-arguments check normally imposes that virtual methods have no default arguments. For our use-cases, all implementations of such methods are expected to use the same default arguments, and thus this check is manually disabled via NOLINT comments. However, this is not done consistently. This commit cleans this up and clarifies our intent by: - removing the default values (and the NOLINT statement) for all implementations of virtual methods with default argument values, matching the desired intended behaviour, but - keeping the clang-tidy check for future cases where derived classes would want to provide each different defaults. | |||
9 days | ExecutionAPI: Support output_paths in requests | Oliver Reiche | |
... and prepare local execution for clients using only RBEv2.1 (setting only output_paths). | |||
9 days | ExecutionAPI: Support output_symlinks in response | Oliver Reiche | |
9 days | ExecutionApi: Drop DirectorySymlinks from common api | Oliver Reiche | |
... as it is only needed for local execution, there is no need to provide it in the common api interface. | |||
9 days | LocalAction: Fix the use of external logger | Oliver Reiche | |
2025-06-16 | Avoid unnecessary work in accessing container entries | Paul Cristian Sarbu | |
- in sequence containers, use operator[] instead of .at() when accessing indices guaranteed to be in bound; - in associative containers, prefer .find() and reusing the returned const iterator to using .contains() and .at(); while there, make any so obtained iterators const if they are read-only. | |||
2025-06-04 | Executor: Check validity of action outputs in compatible mode | Paul Cristian Sarbu | |
This ensures that any entries that the standard remote execution protocol accepts but are invalid in justbuild, i.e., upwards symlinks, are rejected. For this purpose, do not fail in the action response instances, just perform the check there, as all required information is available, and set a flag that the executor can check as needed. | |||
2025-06-04 | {Local,Bazel}Response: Fix logic for marking succesful population | Paul Cristian Sarbu | |
While in practice a failure to populate the fields of a response happens once per invocation, as it will trigger a failure of the execution, from an algorithmic standpoint the flag to mark a successful population of the response fields should only be set on actual success. Fix this. | |||
2025-06-04 | LocalCasReader: Add validity check for bazel directories | Paul Cristian Sarbu | |
This will check if directories contain upwards symlinks. | |||
2025-05-12 | LocalAction: Fix collection of directory symlink | Oliver Reiche | |
2025-04-22 | FileSystemManager: Always remove directories recursively | Maksim Denisov | |
2025-03-24 | LocalApi: Use file sources of ArtifactBlobs. | Maksim Denisov | |
2025-03-24 | ExecutionApi: Return TmpDir | Maksim Denisov | |
2025-03-24 | TmpDir: minor refactoring | Maksim Denisov | |
2025-03-24 | Remove redundant UpdateContainerAndUpload. | Maksim Denisov | |
2025-03-17 | execution_api: support reading off stdout/stderr digests | Klaus Aehlig | |
2025-03-10 | local actions: return duration | Klaus Aehlig | |
2025-03-10 | execution response interface: include execution duration | Klaus Aehlig | |
2025-02-28 | Avoid rehashing content when using GitRepo::ReadTreeData | Maksim Denisov | |
2025-02-28 | Include ArtifactDigestFactory into "common" library | Maksim Denisov | |
2025-02-27 | LocalApi: Create ArtifactBlobs from existing files | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Use static function for construction | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Check access to the content | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Convert to a class | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Move from execution_api/common to common | Maksim Denisov | |
2025-02-21 | LocalCasReader: Use IncrementalReader | Maksim Denisov | |
2025-02-20 | Separate off id generation to a separate library | Klaus Aehlig | |
... and rename appropriately to reflect contents more precisely than the generic "common". This separation also disentangles dependencies a bit. | |||
2025-02-19 | LocalApi: Use BackMap to get missing digests | Maksim Denisov | |
2025-02-19 | IExecutionApi: Return supported HashFunction::Type | Maksim Denisov | |
2025-02-19 | LocalApi: rename library "local" => "local_api" | Maksim Denisov | |
2025-02-19 | LocalApi: Add cpp file | Maksim Denisov | |
2025-02-19 | GitApi: rename library "git" => "git_api" | Maksim Denisov | |
2025-02-07 | Rename artifact_blob_container to artifact_blob | Maksim Denisov | |
2025-02-07 | CommonApi: Remove template parameter from UploadAndUpdateContainer | Maksim Denisov | |
...since it works with ArtifactBlobs only. | |||
2025-02-07 | Replace ArtifactBlobContainer and BazelBlobContainer | Maksim Denisov | |
...with explicit std::unordered_set. | |||
2025-02-07 | Replace ContentBlobContainer<T> with std::unordered_set | Maksim Denisov | |
2025-02-07 | IExecutionApi: Rename IsAvailable to GetMissingDigests | Maksim Denisov | |
2025-02-07 | IExecutionApi: Use unordered_set in IsAvailable | Maksim Denisov | |
2025-01-29 | local api: absence of a git api is not a success in retrieving | Klaus Aehlig | |
While there, also check for availability first, to avoid duplicated error messages (from git_cas and the caller). | |||
2025-01-22 | local api: take git fallback seriously | Klaus Aehlig | |
... and, when asked if an artifact is available, also inspect the git cas. | |||
2024-12-19 | Move functionality for staging from CAS to output paths to TreeReader | Maksim Denisov | |
...and employ it in LocalApi. | |||
2024-12-05 | execution api: support retrieving from more than one API, also for fd | Klaus Aehlig | |
Extend the api to optionally accept a different API for preferred fetching. This is already supported when fetching to a file path; therefore, extend to keep the interface symmetric. | |||
2024-11-29 | Clean up unused deps | Klaus Aehlig | |
2024-11-14 | execution_api remaining: Implement IWYU suggestions | Paul Cristian Sarbu | |
2024-10-25 | Add dependencies explicitly that are included directly | Klaus Aehlig | |
... instead of relying on those dependencies being pulled in indirectly. | |||
2024-10-10 | Remove from OSS intersecting public-private dependencies | Maksim Denisov | |
2024-10-08 | Name local variables using lower_case | Maksim Denisov | |
...and private members using lower_case_ | |||
2024-10-07 | Disable misc-no-recursion check | Maksim Denisov | |
...since we use recursion for trees a lot, but skip this check manually. | |||
2024-10-07 | Enable readability-* checks. | Maksim Denisov | |
2024-10-07 | Enable readability-redundant-member-init check. | Maksim Denisov | |